Clean up and pop dead runspace when using 'attach' #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when you used the
attach
launch config, if you killed the process that you were attaching to while PSES was attached to it, PSES would go into a bad state and hang forever.This was because the Runspace wasn't getting cleaned up properly when the connection between the two processes broke.
This change checks for the bad runspace state, cleans up, and pops the bad runspace.
Here's what you see:
which is very consistent with what pwsh.exe shows when this happens.