Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPInstallPrereq: Added support for detecting updated installation of VC++ redistributable #964

Merged

Conversation

jensotto
Copy link
Contributor

@jensotto jensotto commented Nov 6, 2018

Pull Request (PR) description

Added support for detecting updated installation of Microsoft Visual C++ 2015/2017 Redistributable (x64) for SharePoint 2016 and SharePoint 2019.
Changed required version of Microsoft Visual C++ 2017 Redistributable (x64) to 14.13.26020.0 as this is the version included in the prerequisite installer.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Nov 6, 2018

Codecov Report

Merging #964 into dev will decrease coverage by <1%.
The diff coverage is 92%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #964   +/-   ##
=====================================
- Coverage     92%     92%   -1%     
=====================================
  Files        115     115           
  Lines      11774   11789   +15     
  Branches       1       1           
=====================================
+ Hits       10937   10950   +13     
- Misses       836     838    +2     
  Partials       1       1

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ykuijs ykuijs merged commit a018692 into dsccommunity:dev Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPInstallPrereqs: Does not properly detect installed prerequisites
3 participants