AzureRM Tools extension prevents PowerShell extension from loading #1016

brandubh · 2017-09-01T13:54:55Z

System Details

Operating system name and version: Windows 10 (1703) 15063.540
VS Code version: 1.16.0-insider
PowerShell extension version: 1.4.1
Output from $PSVersionTable:
Name Value

PSVersion 5.1.15063.502
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.15063.502
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Copy / paste the following commands into the PowerShell Integrated Console, and paste the output here:

 code -v
code : The term 'code' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1
+ code -v
+ ~~~~
    + CategoryInfo          : ObjectNotFound: (code:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS> $pseditor.EditorServicesVersion
PS> code --list-extensions --show-versions
code : The term 'code' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1
+ code --list-extensions --show-versions
+ ~~~~
    + CategoryInfo          : ObjectNotFound: (code:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.15063.502
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.502
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
[logs.zip](https://github.com/PowerShell/vscode-powershell/files/1270431/logs.zip)

SerializationVersion           1.1.0.1

Issue Description

Basically the extension after the latest insider updates doesn't work anymore (no F8, no auto complete, and so on), in the output window I can read:
[8:58:45] Language server starting...
[8:58:45] Language server startup failed.

Attached Logs

I attach the logs, but they're empty

The text was updated successfully, but these errors were encountered:

brandubh · 2017-09-08T10:11:48Z

Still present with extension 1.4.2

2017-9-8 12:09:12 [NORMAL] - Visual Studio Code v1.17.0-insider 64-bit
2017-9-8 12:09:12 [NORMAL] - PowerShell Extension v1.4.2
2017-9-8 12:09:12 [NORMAL] - Operating System: Windows 64-bit

2017-9-8 12:09:12 [NORMAL] - Language server starting...
2017-9-8 12:09:12 [NORMAL] - Language server startup failed.

reg-c · 2017-09-08T12:05:43Z

Hi, I am having the same problem here:

Windows 10 (1703) 15063.540

$PSVersionTable:
PSVersion 5.1.15063.502
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.15063.502
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

2017-9-8 14:03:35 [NORMAL] - Visual Studio Code v1.16.0 64-bit
2017-9-8 14:03:35 [NORMAL] - PowerShell Extension v1.4.2
2017-9-8 14:03:35 [NORMAL] - Operating System: Windows 64-bit

2017-9-8 14:03:35 [NORMAL] - Language server starting...
2017-9-8 14:03:35 [NORMAL] - Language server startup failed.

MarvTheRobot · 2017-09-08T12:53:15Z

Me too:

I'd upload the logs, but they are empty. I've changed the logging level to Verbose, still empty.

Name Value

PSVersion 5.1.15063.502
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.15063.502
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

2017-9-8 09:58:50 [NORMAL] - Visual Studio Code v1.17.0-insider 64-bit
2017-9-8 09:58:50 [NORMAL] - PowerShell Extension v1.4.2
2017-9-8 09:58:50 [NORMAL] - Operating System: Windows 64-bit

2017-9-8 09:58:50 [NORMAL] - Language server starting...
2017-9-8 09:58:50 [NORMAL] - Language server startup failed.
2017-9-8 12:07:00 [NORMAL] -

Shutting down language client...
2017-9-8 12:09:13 [NORMAL] -

Shutting down language client...
2017-9-8 12:09:40 [NORMAL] -

Shutting down language client...

daviwil · 2017-09-08T13:39:04Z

Thanks all! @Jaykul also reported this issue to me recently but I haven't yet figured out why it's happening. The logs you've all pasted are a good starting point for investigation so I'll take a look today.

daviwil · 2017-09-08T13:46:23Z

By the way, does this problem occur for you when using VS Code Stable 1.16.0 which was released yesterday, or only in the latest Insiders builds?

MarvTheRobot · 2017-09-08T14:26:40Z

For me it happens on both Stable and Insiders. Fully removed extension and re-installed, same issue. Just fails to load Editor Services and doesn't seem to create any log files.

daviwil · 2017-09-08T14:59:04Z

Damn, not sure what happened there. Seems like it's not launching PowerShell at all. Can you try adding this setting to see if it makes any difference?

"powershell.powerShellExePath": "C:/Windows/System32/WindowsPowerShell/v1.0/powershell.exe"

MarvTheRobot · 2017-09-08T15:48:59Z

@daviwil , thats seems to have worked for me. The default is just "" (I can't remember if it was that normally. Adding the direct path has put everything back to how it was prior to 1.4.2

daviwil · 2017-09-08T15:51:04Z

Thanks a lot for confirming! I'll see if I can get a fix out for that today.

reg-c · 2017-09-11T06:44:27Z

@daviwil adding the powerShellExePath doesn't work for me in the 1.16.0 build, however the extension works with the latest insider build without any changes

richardrobberse · 2017-09-11T18:34:44Z

@daviwil adding the powerShellExePath didn't work for me either, I'm on the 1.16 build.

aydeisen · 2017-09-11T19:54:11Z

@daviwil ditto for me. I'm running VSCode 1.16 on Windows 10 1703, and adding powershell.powerShellExePath. I was hoping it was from switching VSCode from x86 to x64, but neither enabling the x86 PowerShell nor switching back to 32-bit VSCode resolved the issue

aydeisen · 2017-09-11T23:27:27Z

@daviwil I got the vscode-PowerShell extension to work after disabling the 'Azure Tools for Visual Studio Code' extension by 'bradygaster', which is installed as part of the 'Azure Extension Pack' by 'Microsoft'.
https://github.com/bradygaster/azure-tools-vscode

richardrobberse · 2017-09-12T06:29:48Z

@aydeisen This worked for me too, thanks for the tip!

reg-c · 2017-09-12T06:52:17Z

@aydeisen removing the Azure tools also fixed powershell for me. And now after I added the msazurermtools.azurerm-vscode-tools extension again PowerShell still works...

aydeisen · 2017-09-12T11:23:37Z

@cjrege: that extension doesn't look right. It was the bradygaster.azuretoolsforvscode-1.2.9 extension that was the issue. The ms-vscode.powershell-1.4.2 extension continued to work with all of the other Azure extensions included with the ms-vscode.vscode-azureextensionpack

daviwil · 2017-09-12T22:17:02Z

Hey all, thanks a lot for the investigation! It definitely turns out that the Azure Tools for VS Code extension (or more accurately, one of its dependencies) is causing this issue. They use the AppInsights SDK for Node.js which hijacks some standard Node.js APIs to provide instrumentation. Their wrapper of the filesystem module is causing an error to be thrown in a way that prevents the PowerShell extension from being loaded.

I've included some more details here: https://github.com/bradygaster/azure-tools-vscode/issues/46#issuecomment-328999603

Currently trying to find a workaround, I'll ship a patch update as soon as I have something.

…on conflict This change fixes an issue that was illuminated by the AzureRM Tools extension where the `fs.appendFile` method provided by Node.js was not being called with the correct number of parameters. The AzureRM Tools extension loads up the AppInsights SDK for Node.js which in turn loads a module called Zone.js. Zone.js replaces built-in Node.js modules like `fs` to instrument their function calls. The instrumented version of that module was not as permissive on our missing `appendFile` parameter so it threw an exception which ultimately prevented the PowerShell extension from loading. This issue was fixed by populating the `callback` parameter of the `appendFile` function so that the instrumented wrapper operates correctly.

daviwil · 2017-09-13T15:29:01Z

Just shipped 1.4.3 with a fix for this issue, let me know how it goes for you!

aydeisen · 2017-09-13T18:03:05Z

@daviwil I can confirm that the Integrated terminal, along with the PowerShell extension, are now loading properly with bradygaster's Azure Tools for Visual Studio Code enabled.

Thanks for the quick turnaround.

daviwil · 2017-09-13T20:47:42Z

Fantastic, thanks for confirming, and thanks again for the diagnostic assistance!

brandubh · 2017-09-14T07:45:43Z

Great! It solves the issue. Thx a mil.

adarobin · 2017-10-03T13:11:28Z

@daviwil There is still something weird going on with this extension on macOS. I have to disable the Azure Tools for Visual Studio extension to get the PowerShell Integrated Console to display anything. If I don't disable that extension, the PowerShell Integrated Console just sits like this forever:

The verbose logs don't seem to contain anything useful:

EditorServices.log
vscode-powershell.log

andystumph · 2017-10-03T13:41:23Z

I still experienced it on 1.4.3 as well. Had to disable Azure Tools to get the integrated console to launch. Running on Windows 8.1 though.

aydeisen · 2017-10-03T14:31:07Z

I’m not seeing the issue reemerge on my Windows 10 machine. The PS Integrated Console has been taken a little longer to load, but I assume that’s more of a vscode issue than a PowerShell Extension issue. - VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z) - OS Version: Windows_NT x64 10.0.15063 - Extensions: Extension|Author (truncated)|Version ---|---|--- jslint|ajh|1.2.1 azuretoolsforvscode|bra|1.3.0 jshint|dba|0.10.15 vscode-eslint|dba|1.3.2 azure-functions-tools|joh|0.3.1 vscode-devskim|MS-|0.2.0 mssql|ms-|1.2.0 azurecli|ms-|0.3.0 csharp|ms-|1.12.1 github-issues-prs|ms-|0.6.0 js-atom-grammar|ms-|0.1.13 PowerShell|ms-|1.4.3 typescript-javascript-grammar|ms-|0.0.24 vscode-azureextensionpack|ms-|0.0.6 team|ms-|1.122.0 azurerm-vscode-tools|msa|0.3.7 vscode-docker|Pet|0.0.18 velocity|sod|0.1.0 usql-vscode-ext|usq|0.2.4 application-insights|Vis|0.4.1 azure-iot-toolkit|vsc|0.2.3 Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10 From: Andy Stumph<mailto:notifications@github.com> Sent: Tuesday, October 3, 2017 09:41 To: PowerShell/vscode-powershell<mailto:vscode-powershell@noreply.github.com> Cc: aydeisen<mailto:aydeisen@gmail.com>; Mention<mailto:mention@noreply.github.com> Subject: Re: [PowerShell/vscode-powershell] AzureRM Tools extension prevents PowerShell extension from loading (#1016) I still experienced it on 1.4.3 as well. Had to disable Azure Tools to get the integrated console to launch. Running on Windows 8.1 though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1016 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANZGFeCUzIHtG40shVZwe3vUj5Szk7z6ks5sojmKgaJpZM4PKLq5>.

daviwil added Area-Language Server Issue-Bug A bug to squash. labels Sep 8, 2017

daviwil added this to the 1.4.3 milestone Sep 8, 2017

daviwil changed the title ~~Extension stopped working in latest builds~~ AzureRM Tools extension prevents PowerShell extension from loading Sep 13, 2017

daviwil mentioned this issue Sep 13, 2017

Release 1.4.3 #1032

Closed

daviwil mentioned this issue Sep 13, 2017

Merge 1.4.3 release #1033

Merged

daviwil closed this as completed in 43c6cc3 Sep 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AzureRM Tools extension prevents PowerShell extension from loading #1016

AzureRM Tools extension prevents PowerShell extension from loading #1016

brandubh commented Sep 1, 2017

brandubh commented Sep 8, 2017

reg-c commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017

daviwil commented Sep 8, 2017

daviwil commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017 •

edited

daviwil commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017

daviwil commented Sep 8, 2017

reg-c commented Sep 11, 2017

richardrobberse commented Sep 11, 2017

aydeisen commented Sep 11, 2017

aydeisen commented Sep 11, 2017 •

edited

richardrobberse commented Sep 12, 2017

reg-c commented Sep 12, 2017

aydeisen commented Sep 12, 2017 •

edited

daviwil commented Sep 12, 2017

daviwil commented Sep 13, 2017

aydeisen commented Sep 13, 2017

daviwil commented Sep 13, 2017

brandubh commented Sep 14, 2017

adarobin commented Oct 3, 2017

andystumph commented Oct 3, 2017

aydeisen commented Oct 3, 2017 via email

AzureRM Tools extension prevents PowerShell extension from loading #1016

AzureRM Tools extension prevents PowerShell extension from loading #1016

Comments

brandubh commented Sep 1, 2017

System Details

Issue Description

Attached Logs

brandubh commented Sep 8, 2017

reg-c commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017

daviwil commented Sep 8, 2017

daviwil commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017 • edited

daviwil commented Sep 8, 2017

MarvTheRobot commented Sep 8, 2017

daviwil commented Sep 8, 2017

reg-c commented Sep 11, 2017

richardrobberse commented Sep 11, 2017

aydeisen commented Sep 11, 2017

aydeisen commented Sep 11, 2017 • edited

richardrobberse commented Sep 12, 2017

reg-c commented Sep 12, 2017

aydeisen commented Sep 12, 2017 • edited

daviwil commented Sep 12, 2017

daviwil commented Sep 13, 2017

aydeisen commented Sep 13, 2017

daviwil commented Sep 13, 2017

brandubh commented Sep 14, 2017

adarobin commented Oct 3, 2017

andystumph commented Oct 3, 2017

aydeisen commented Oct 3, 2017 via email

MarvTheRobot commented Sep 8, 2017 •

edited

aydeisen commented Sep 11, 2017 •

edited

aydeisen commented Sep 12, 2017 •

edited