Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Project experience doesn't open project folder correctly in some cases #390

Closed
daviwil opened this issue Dec 16, 2016 · 1 comment
Closed
Labels
Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented Dec 16, 2016

Destination paths like the following don't open correctly:

  • ~/MyNewModule
  • $HOME/MyNewModule

We should resolve these paths in the language server and send back the full path to the new workspace so that VS Code doesn't need to resolve the path (especially in the case of using PowerShell variables like $HOME).

@daviwil daviwil added the Issue-Bug A bug to squash. label Dec 16, 2016
@daviwil daviwil added this to the 0.8.1 milestone Dec 16, 2016
@daviwil
Copy link
Contributor Author

daviwil commented Dec 17, 2016

Ultimately depends on PowerShellOrg/Plaster#218 being wired up through Editor Services.

@rkeithhill rkeithhill assigned rkeithhill and unassigned rkeithhill Dec 17, 2016
daviwil added a commit to PowerShell/PowerShellEditorServices that referenced this issue Jan 18, 2017
This change fixes PowerShell/vscode-powershell#390 which states that the
New Project experience in VS Code doesn't work well with project paths
which use characters like '~' to represent the home directory.  This
change causes the fully resolved DestinationPath of the template creation
to be passed back to the editor so that it can be opened.
daviwil added a commit to PowerShell/PowerShellEditorServices that referenced this issue Jan 18, 2017
This change fixes PowerShell/vscode-powershell#390 which states that the
New Project experience in VS Code doesn't work well with project paths
which use characters like '~' to represent the home directory.  This
change causes the fully resolved DestinationPath of the template creation
to be passed back to the editor so that it can be opened.
@daviwil daviwil modified the milestones: 0.9.0, 0.10.0 Jan 18, 2017
@daviwil daviwil modified the milestones: 0.11.0, 0.10.0 Mar 14, 2017
@daviwil daviwil modified the milestones: 0.11.0, 0.12.0 Mar 22, 2017
@daviwil daviwil modified the milestones: 0.12.0, Next Patch Update, Next Feature Update Apr 4, 2017
@daviwil daviwil modified the milestones: April 2017, May 2017 May 8, 2017
@daviwil daviwil added this to the 1.3.0 milestone May 22, 2017
@daviwil daviwil removed this from the May 2017 milestone May 22, 2017
@daviwil daviwil modified the milestones: 1.3.0, June 2017 Jun 1, 2017
@daviwil daviwil modified the milestones: June 2017, July 2017 Jul 11, 2017
@daviwil daviwil modified the milestones: July 2017, Future Oct 26, 2017
@TylerLeonhardt TylerLeonhardt modified the milestone: Future May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

4 participants