Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger does not start in the correct window when multiple windows are open. #626

Closed
daleecc opened this issue Mar 28, 2017 · 3 comments
Closed
Labels
Milestone

Comments

@daleecc
Copy link

daleecc commented Mar 28, 2017

System Details

  • Operating system name and version: Windows 7 (64-bit)
  • VS Code version: 1.10.2
  • PowerShell extension version: 0.11
  • Output from $PSVersionTable:
Name                           Value
----                           -----
PSVersion                      5.0.10586.117
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.117
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

When debugging with multiple VSCode windows open (both with PowerShell), the debugging may not be performed in the correct window.

Steps to reproduce:

  1. Open a VSCode window and load a PowerShell file. Wait for the Integrated Terminal to start.
  2. Open a second VSCode window and load a different PowerShell file. Wait for the Integrated Terminal to start.
  3. Start the debugger for the PowerShell in the first window. The script will be executed in the Integrated Terminal of the second window.
@daviwil
Copy link
Contributor

daviwil commented Mar 28, 2017

Wow! Does this happen every time you try it? I have a theory on why it's happening, will try to fix it for an update this week.

@daviwil daviwil added this to the Next Patch Update milestone Mar 28, 2017
@daviwil daviwil added Area-Debugging Issue-Bug A bug to squash. labels Mar 28, 2017
@daleecc
Copy link
Author

daleecc commented Mar 28, 2017

Yep I can reproduce this consistently with the method above.

@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Apr 6, 2017
@Bounz
Copy link

Bounz commented Apr 12, 2017

I can reproduce this bug also.
VS Code version: 1.10.1
PowerShell extension version: 0.12.2
$PSVersionTable:

Name                           Value
----                           -----
PSVersion                      4.0
WSManStackVersion              3.0
SerializationVersion           1.1.0.1
CLRVersion                     4.0.30319.42000
BuildVersion                   6.3.9600.16406
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.2

@daviwil daviwil modified the milestones: April 2017, May 2017, 1.0.0-beta1 May 8, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 10, 2017
This change fixes an issue where multiple VS Code windows would
inadvertently share the same language server and debug adapter ports,
causing one of the windows to send all of its output and behavior to the
other window.  The fix is to make session file management more unique
between each window in the same VS Code process.

Resolves PowerShell#626.
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 10, 2017
This change fixes an issue where multiple VS Code windows would
inadvertently share the same language server and debug adapter ports,
causing one of the windows to send all of its output and behavior to the
other window.  The fix is to make session file management more unique
between each window in the same VS Code process.

Resolves PowerShell#626.
daviwil added a commit that referenced this issue May 10, 2017
This change fixes an issue where multiple VS Code windows would
inadvertently share the same language server and debug adapter ports,
causing one of the windows to send all of its output and behavior to the
other window.  The fix is to make session file management more unique
between each window in the same VS Code process.

Resolves #626.
@daviwil daviwil modified the milestones: 1.0.0, May 2017 May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants