Add poweshell.helpCompletion setting to control/disable feature #1282
Conversation
Changing this setting does require a reload window. Trigger sequence changed to just "##". Fix #1228
There was a problem hiding this comment.
LGTM @rkeithhill! Great as always 😀
Just a couple questions but otherwise this is good to go!
src/features/HelpCompletion.ts
Outdated
|
|
||
| constructor() { | ||
| this.triggerFinderBlockComment = new TriggerFinder("<#"); | ||
| this.triggerFinderLineComment = new TriggerFinder("##"); |
There was a problem hiding this comment.
Could this be set to the settings value rather than "##"? One less string to manage. If it's less performant we don't have to do this change.
There was a problem hiding this comment.
Regardless of the settings value (BlockComment or LineComment), the trigger sequence is always ##. Perhaps I'm not following the ask here??
There was a problem hiding this comment.
Oh! I see now, you're right. Somehow I was thinking you could set the trigger to Block or Line. <# or ##. Ignore me :)
src/features/HelpCompletion.ts
Outdated
| } | ||
|
|
||
| public get triggerFound(): boolean { | ||
| return this.triggerFinderBlockComment.found || this.triggerFinderLineComment.found; | ||
| return this.triggerFinderLineComment.found; |
There was a problem hiding this comment.
Since we only have the one variable now, could this be renamed to triggerFinderHelpComment so that it's more apparent this applies to both block and line?
Changing this setting does require a reload window.
Trigger sequence changed to just "##".
Fix #1228