Bundle the extension #3555
Merged
Bundle the extension #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Build & Release
Issue-Enhancement
|
Wow, so this is really annoying. The tooling is absolutely not ready for tests yet. |
andyleejordan
force-pushed
the
andschwa/bundle
branch
from
1ec5b76
to
956320d
Compare
|
@rjmholt and @SeeminglyScience please test this (and especially the launch configurations). Everything seems to be working right but it wasn't trivial. |
While we need to bundle the extension code with `eslint` we still have to use `tsc` for the tests, which is annoying. This also fixes are (already broken) VS Code launch tasks!
Since bundling produces a single (bundled) file at `out/main.js` all the relative paths that expected `out/src/...` needed to drop one set of `../` to be correct. We cannot emit the bundled extension to `out/src/main.js` because, as mentioned previously, we still must transpile everything for the unit tests, so `out/src/` is already full.
It's still 64-bit just not `x64`.
andyleejordan
force-pushed
the
andschwa/bundle
branch
from
956320d
to
82c120d
Compare
|
Also filed #3561 as a next step. |
rjmholt
approved these changes
Sep 13, 2021
Comment on lines
+3
to
+4
| // NOTE: The TypeScript compiler is only used for building the tests (and | ||
| // the sources which the tests need). The extension is built with `esbuild`. |
There was a problem hiding this comment.
Does this file configure the typescript compiler rather than esbuild?
There was a problem hiding this comment.
Yes, T(ype)S(cript)config.json. While esbuild supports transpiling typescript to javascript, it does not do any sort of type checking etc., and it also will only produce a bundled file. So we still need tsc around to type-check the sources and transpile the test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
esbuildas outlined in the VS Code docs to bundle the PowerShell extension.Resolves #2450.