Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about intellisense to PSIC terminate dialog #3976

Merged
merged 2 commits into from May 12, 2022

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented May 12, 2022

This came up in a user group that many people weren't aware of, so I think enhancing this message is appropriate.

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

This came up in a user group that many people weren't aware of, so I think enhancing this message is appropriate.
@JustinGrote JustinGrote requested a review from a team as a code owner May 12, 2022 21:31
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with this one change!

src/session.ts Outdated Show resolved Hide resolved
@andyleejordan andyleejordan enabled auto-merge (squash) May 12, 2022 23:48
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-UI labels May 12, 2022
@andyleejordan andyleejordan merged commit da1fd80 into master May 12, 2022
@andyleejordan andyleejordan deleted the docs/IntellisenseWarning branch May 12, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants