Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new debug configurations to package.json #4516

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Apr 13, 2023

PR Summary

Currently, the initial debug configurations are not populating from provideDebugConfiguration. They must be manually populated into the package.json to work with the Add Configuration button in an existing launch.json

Reference: microsoft/vscode#150663 (comment)

Also register debug session handler for both dynamic and initial in the event this ever does get fixed.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Also register debug session handler for both dynamic and initial
@JustinGrote JustinGrote requested a review from a team as a code owner April 13, 2023 03:47
@JustinGrote JustinGrote self-assigned this Apr 13, 2023
@JustinGrote JustinGrote enabled auto-merge (squash) April 13, 2023 03:47
@andyleejordan andyleejordan changed the title Add new Debug Configurations to package.json Add new debug configurations to package.json Apr 14, 2023
@JustinGrote JustinGrote merged commit f3a44b8 into main Apr 14, 2023
13 checks passed
@JustinGrote JustinGrote deleted the feature/debugConfigProvider-Initial branch April 14, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants