Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template and issue templates #154

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Add pull request template and issue templates #154

merged 2 commits into from
Sep 6, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 20, 2018

This is an automatic batch pull request.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #154 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #154   +/-   ##
===================================
  Coverage    76%    76%           
===================================
  Files        11     11           
  Lines      1236   1236           
===================================
  Hits        942    942           
  Misses      294    294

@johlju
Copy link
Member Author

johlju commented Aug 20, 2018

Pull-request updated, HEAD is now 4630f2c

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Aug 23, 2018
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Sep 6, 2018
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 2e0f6b3 into dsccommunity:dev Sep 6, 2018
@johlju johlju deleted the add-templates branch September 6, 2018 09:32
@johlju johlju removed the needs review The pull request needs a code review. label Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants