Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xNetConnectionProfile always returns falls when not passing all parameters. #254

Closed
dcrreynolds opened this issue Aug 11, 2017 · 1 comment · Fixed by #256
Closed

xNetConnectionProfile always returns falls when not passing all parameters. #254

dcrreynolds opened this issue Aug 11, 2017 · 1 comment · Fixed by #256
Assignees
@PlagueHO
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.

Comments

@dcrreynolds
Copy link

Test-TargetResource returns false when parameters IPv4Connectivity, IPv6Connectivity, or NetworkCategory are not provided. These option parameters are treated and evaluated as if they could not be null.

I think we should check for NullOrWhitespace before returning false. A validation check that at least one of the 3 parameters was used may be a nice add as well.
@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Aug 11, 2017
@PlagueHO
Copy link
Member

Cool - thanks @dcrreynolds - I'll see if I can get to this one today. Cheers for submitting!

This was referenced Aug 12, 2017
Closed
Merged
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 12, 2017
tysonjhayes pushed a commit that referenced this issue Aug 15, 2017
Merge pull request #256 from PlagueHO/Issue-254
6438ee0 
[xNetConnectionProfile] Enable setting only some parameters and validate parameters - Fixes #254
@SteveL-MSFT SteveL-MSFT added this to In progress in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from In progress in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[xNetConnectionProfile] Enable setting only some parameters and validate parameters - Fixes #254
2 participants
@PlagueHO @dcrreynolds