Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xNetConnectionProfile] Enable setting only some parameters and validate parameters - Fixes #254 #256

Merged
merged 3 commits into from
Aug 15, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Aug 12, 2017

Pull Request (PR) description
Change xNetConnectionProfile so that the parameters are validated so that at least one is set. Also only compares values that were passed, enabling the resource to only set specific parameters.

Corrected xNetConnectionProfile to meet HQRM and converted exceptions to use ResourceHelper functions.

This Pull Request (PR) fixes the following issues:
Fixes #254
Fixes #255

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Aug 12, 2017
@PlagueHO PlagueHO added this to the HQRM milestone Aug 12, 2017
@PlagueHO PlagueHO self-assigned this Aug 12, 2017
@PlagueHO PlagueHO changed the title Issue 254 [xNetConnectionProfile] Enable setting only some parameters and validate parameters - Fixes #254 Aug 12, 2017
@codecov-io
Copy link

codecov-io commented Aug 12, 2017

Codecov Report

Merging #256 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #256    +/-   ##
====================================
+ Coverage    97%    97%   +<1%     
====================================
  Files        18     18            
  Lines      1376   1387    +11     
====================================
+ Hits       1339   1351    +12     
+ Misses       37     36     -1

@tysonjhayes
Copy link
Collaborator

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

Hi @tysonjhayes - I have rebased this to fix the merge conflicts - should be good to go! Thanks buddy! 😁

@tysonjhayes
Copy link
Collaborator

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@tysonjhayes tysonjhayes merged commit 6438ee0 into dsccommunity:dev Aug 15, 2017
@dcrreynolds
Copy link

Awesome, thanks!

@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Aug 15, 2017
@PlagueHO PlagueHO deleted the Issue-254 branch August 16, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants