This repository has been archived by the owner on May 15, 2018. It is now read-only.
Resource updates #68
Merged
Resource updates #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Using an updated version of Test-cDscResource for this; that will be sent along in a separate pull request soon.
Updated cSqlServerInstall resource to pass Test-cDscResource. Removed duplicate resources from the DSCResources folder; not sure why there were versions both with and without the PSHOrg prefix. Not sure what a copy of cScriptResource is doing in here either, but I'll revisit that later.
Fixed several compilation errors due to missing newlines. Resource now passes Test-cDscResource.
In testing, noticed that the LCM will fail to apply configurations if the Get-TargetResource method doesn't accept both key AND required properties from the schema.mof file as parameters. cWebsite has been updated to reflect this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several resources were failing Test-cDscResource, and have been updated to address these failures.
There were also duplicate copies of just about every resource in the cSqlPs module, for some reason. I've removed the folders that had no prefix, leaving the PSHOrg_* resource folders intact.
On a side note, there is also a copy of cScriptResource in the cSqlPs module. Not sure what it's doing there. It's also not working properly at the moment, but I've left it alone until I understand why it's there in the first place.
I've been tweaking Test-cDscResource recently, and these tests were performed with the updated version. It's possible that some of the resources may not pass with the version that's currently up in the PowerShell.org repo. I'll be submitting a pull request with tooling updates soon.