[next] -- fix for colors

[Artistan]

terminals do not always render named colors
when using parameter expansion.

• check if named color renders (dynamic)
• if not use the colorCode
• getColorCode executable with (foreground|background) to show example in terminal
• only 2 places render colors, so it is an easy fix.

#702

[Artistan]

@bhilburn - this will fix the colors in next.

[bhilburn]

@Artistan - So sorry for the long response time, here! I've been traveling and such for the holidays. I'm back and ready to get this resolved & merged =)

So, unfortunately, while this PR improves the situation on next, it doesn't completely resolve it for me. This is what I see with this branch:

As you can see, it fixed the background color of the history segment, but not for the separator. Thoughts, @Artistan?

[Artistan]

Can you post your config or send me a PM?
I can test that out on my setup.

I have also noticed an issue with transparency in iterm2 and the separators not matching the colors either, but I think that is another issue.

[bhilburn]

@Artistan - You can find my zshrc here: macos-zshrc

I see the issues with both iTerm 3.0.15 and 3.1.5 (latest).

[Artistan]

@bhilburn -- looks like the white arrow on the right side is using the foreground color instead of the next color...

[Artistan]

another place where the new color functions needed to be used to ensure proper color when using names.

[Artistan]

fix added for issue #711

[bhilburn]

@Artistan - Looks like everything is working as expected! Thanks so much for putting in the time & effort to get this hammered out. I'm really excited about having better color support in P9k =)

[mavam]

Commit 4d18fdc, which is now in next, introduces the following coloring bug for me:

Before:

As can be seen, the background is no longer the right color. I have been working with the color clear in my config a lot, perhaps that's the issue. Here's a snippet:

POWERLEVEL9K_VCS_CLEAN_BACKGROUND="clear"
POWERLEVEL9K_VCS_CLEAN_FOREGROUND="green"
POWERLEVEL9K_VCS_MODIFIED_BACKGROUND="clear"
POWERLEVEL9K_VCS_MODIFIED_FOREGROUND="yellow"
POWERLEVEL9K_VCS_UNTRACKED_BACKGROUND="clear"
POWERLEVEL9K_VCS_UNTRACKED_FOREGROUND="yellow"
POWERLEVEL9K_DIR_HOME_BACKGROUND="clear"
POWERLEVEL9K_DIR_HOME_FOREGROUND="blue"
POWERLEVEL9K_DIR_HOME_SUBFOLDER_BACKGROUND="clear"
POWERLEVEL9K_DIR_HOME_SUBFOLDER_FOREGROUND="blue"
POWERLEVEL9K_DIR_WRITABLE_FORBIDDEN_BACKGROUND="clear"
POWERLEVEL9K_DIR_WRITABLE_FORBIDDEN_FOREGROUND="red"
POWERLEVEL9K_DIR_DEFAULT_BACKGROUND="clear"
POWERLEVEL9K_DIR_DEFAULT_FOREGROUND="cyan"
POWERLEVEL9K_ROOT_INDICATOR_BACKGROUND="clear"
POWERLEVEL9K_ROOT_INDICATOR_FOREGROUND="red"
POWERLEVEL9K_STATUS_OK_BACKGROUND="clear"
POWERLEVEL9K_STATUS_OK_FOREGROUND="green"
POWERLEVEL9K_STATUS_ERROR_BACKGROUND="clear"
POWERLEVEL9K_STATUS_ERROR_FOREGROUND="red"
POWERLEVEL9K_TIME_FORMAT="%D{\uf073 %b %d \uf017 %H:%M}" #  Jun 15  09:32
POWERLEVEL9K_TIME_FOREGROUND="blue"
POWERLEVEL9K_TIME_BACKGROUND="clear"
POWERLEVEL9K_TIME_FOREGROUND="blue"
POWERLEVEL9K_COMMAND_EXECUTION_TIME_BACKGROUND='clear'
POWERLEVEL9K_COMMAND_EXECUTION_TIME_FOREGROUND='magenta'
POWERLEVEL9K_BACKGROUND_JOBS_BACKGROUND='clear'
POWERLEVEL9K_BACKGROUND_JOBS_FOREGROUND='magenta'
POWERLEVEL9K_USER_DEFAULT_BACKGROUND='clear'
POWERLEVEL9K_USER_DEFAULT_FOREGROUND='cyan'
POWERLEVEL9K_USER_ROOT_BACKGROUND='clear'
POWERLEVEL9K_USER_ROOT_FOREGROUND='red'
POWERLEVEL9K_USER_ICON="\uf415" # 
POWERLEVEL9K_ROOT_ICON="\u26a1" # ⚡
POWERLEVEL9K_HOST_LOCAL_BACKGROUND='clear'
POWERLEVEL9K_HOST_LOCAL_FOREGROUND='cyan'
POWERLEVEL9K_HOST_REMOTE_BACKGROUND='clear'
POWERLEVEL9K_HOST_REMOTE_FOREGROUND='magenta'
POWERLEVEL9K_HOST_ICON="\uF109 " # 
POWERLEVEL9K_SSH_ICON="\uF489 "  # 
POWERLEVEL9K_OS_ICON_BACKGROUND="clear"
POWERLEVEL9K_OS_ICON_FOREGROUND="grey"

Any guidance on how to keep using next would be appreciated.

(I'm using iTerm 3.1.5 on macOS High Sierra.)

[Artistan]

@mavam - can you post your iterm settings also?

part of the next updates, is support for the iterm color names/settings...

[mavam]

@Artistan I'm using a Solarized theme: