This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Rbenv prompt option always displays #777 #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 3, 2018
ghost
commented
- Add environment variable POWERLEVEL9K_RBENV_PROMPT_ALWAYS_SHOW to set the rbenv prompt segment to show if the local Ruby version is the same as the global Ruby version.
- This also includes a small bugfix where
$(which rbenv) would return the actual function, so $ (command which rbenv) returns the result of calling the function. - Update Readme with description for setting POWERLEVEL9K_RBENV_PROMPT_ALWAYS_SHOW
…ompt_rbenv if rbenv_version_name is the same as rbenv_global
ghost
mentioned this pull request
|
Well done, @RyanDav! Thanks so much for implementing this enhancement, documenting it, and submitting the PR! I'm happy to have this upstreamed. Congrats on your first PR, and welcome to P9k! |
|
Woo! Really pleased to be involved with Powerlevel9k, and having my first PR merged :) It's great to have done a small service for rubyists and P9k users |
ghost
deleted the
dritter
added a commit
to dritter/powerlevel9k
that referenced
this pull request
Jun 6, 2018
Conflicts were: - README.md: Two commits targeted the brightness table. Powerlevel9k#781 from 14. April 2018 on master and Powerlevel9k#684 from 05. December 2017 on next. - powerlevel9k.zsh-theme: Two commits targeted the rbenv segment. Both achieve the same thing: To show the Ruby version number always. Powerlevel9k#795 on next from 14. April 2018 and Powerlevel9k#610 on master from 28. September 2017. I went with Powerlevel9k#795 here as this - although being newer - is the one on master, and that should be more stable.
dritter
added a commit
to dritter/powerlevel9k
that referenced
this pull request
Jun 6, 2018
Conflicts were: - README.md: Two commits targeted the brightness table. Powerlevel9k#781 from 14. April 2018 on master and Powerlevel9k#684 from 05. December 2017 on next. - powerlevel9k.zsh-theme: Two commits targeted the rbenv segment. Both achieve the same thing: To show the Ruby version number always. Powerlevel9k#795 on next from 14. April 2018 and Powerlevel9k#610 on master from 28. September 2017. I went with Powerlevel9k#795 here as this - although being newer - is the one on master, and that should be more stable.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.