Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict_min_version – compatibility with Waterfox Classic #7

Closed
grahamperrin opened this issue Dec 2, 2019 · 11 comments
Closed

strict_min_version – compatibility with Waterfox Classic #7

grahamperrin opened this issue Dec 2, 2019 · 11 comments

Comments

@grahamperrin
Copy link

Hi

Re: https://redd.it/e4atfn and https://addons.mozilla.org/addon/scroll-to-top-button-extension/versions/

  • 7.3.0 is compatible with Waterfox Classic 2019.10
  • 8.1.0 and 8.1.1 are not.

tl;dr historically, Waterfox 56.0 was based on Firefox 56.0.2.

Please update the listings at AMO.

With or without a fix (for compatibility), please add a strict_min_version to the next release.

Thanks
@PoziWorld
Copy link
Owner

Hi @grahamperrin,

Thank you for the report!

Will look into it and report back.

@PoziWorld
Copy link
Owner

It's related to webcomponents/webcomponentsjs#846.

Looking into how to best resolve it.

@PoziWorld
Copy link
Owner

Still looking into it.

There are multiple issues stemming from the fact that the extension now uses Web Components, specifically custom elements and shadow DOM.

Another related issue: mozilla/webextension-polyfill#105

@PoziWorld
Copy link
Owner

Found a very hacky way to make the extension work in Waterfox Classic 2019.10, but it needs a little bit of testing and cleanup before it's shipped.

Will let you know.

@PoziWorld
Copy link
Owner

It seems that Waterfox ignores strict_min_version while in the add-on debugging mode.
Wonder whether it will honor the min version when installing from AMO.

Tried "strict_min_version": "57.0", "strict_min_version": "75.0" and "strict_min_version": "2019.12" in Waterfox Classic 2019.10, but the extension still gets installed, while Firefox 72 does show an error and prevents installation:
image

@lucknaumann
Copy link

@PoziWorld Thanks for all your work in sleuthing this conundrum.

Wonder whether it will honor the min version when installing from AMO.

It should. See here and image (same as at link):
AutoTabDiscard1

@PoziWorld
Copy link
Owner

@lucknaumann,

Thanks for all your work in sleuthing this conundrum.

Thank you for your support, feedback, and help!

It should.

You are right! Waterfox doesn't show the warning/error at about:debugging#addons, but it does show it at about:addons, apparently.

@lucknaumann
Copy link

@PoziWorld Glad you got it working! 😃 And you're very welcome! 😊

PoziWorld added a commit to PoziWorld/polyfills that referenced this issue Dec 31, 2019
@PoziWorld
Change: remove prototype instanceof Object check*
0672102 
* It didn't work as expected in Waterfox Classic v2019.10, which is based on Firefox v56:
```
prototype.__proto__: HTMLElementPrototype
prototype instanceof Object: false
prototype instanceof HTMLElement: true
prototype instanceof Element: false
HTMLElement instanceof Object: true
Element instanceof Object: false
```

Chrome v49, v79:
```
prototype.__proto__: Element
prototype instanceof Object: true
prototype instanceof HTMLElement: true
prototype instanceof Element: true
HTMLElement instanceof Object: true
Element instanceof Object: true
```

See PoziWorld/Scroll-To-Top-Button-extension#7
@PoziWorld
Copy link
Owner

Alright, looks like it works now in Watefox Classic 2019.10:

image

image

@grahamperrin, thank you for the report!

@lucknaumann, thank you for your help!

@lucknaumann
Copy link

lucknaumann commented Dec 31, 2019 •
edited
Loading

@PoziWorld & anyone else who wants to know.

  • Waterfox Classic updated to version 2019.12 a few weeks ago (December 09, 2019).
  • This is the WF version I currently have.
  • I had this add-on on hold with version 7.3.0.
  • I let the browser update this add-on today (December 31, 2019) and it's now at version 8.1.2.0 and works perfectly well. (Yes, expected but wanted to confirm with this version of WF.)

@PoziWorld
Copy link
Owner

@lucknaumann, thank you for getting back with this detailed report! It means a lot.

@PoziWorld PoziWorld mentioned this issue Jan 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grahamperrin @PoziWorld @lucknaumann