Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inputs to be an ordered list of tuples #255

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Allow inputs to be an ordered list of tuples #255

merged 2 commits into from
Dec 10, 2018

Conversation

devonestes
Copy link
Collaborator

Now if inputs are given as an ordered list of tuples, the output will be
in the same order as the list of inputs given instead of sorted by the
input alphabetically.

I also updated some dependencies to get them on the same page as the
formatters, and fixed some Credo issues.

I plan on doing a really big update to the documentation after the next
PR that removes all the deprecated stuff, so I did some updates now,
but I didn't focus on it too much.

Resolves #123

@devonestes devonestes force-pushed the Issue-123 branch 2 times, most recently from 715a7ea to 5e96609 Compare November 23, 2018 11:37
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fabulous, most comments minor

img_20180805_081900

lib/benchee/configuration.ex Outdated Show resolved Hide resolved
lib/benchee/configuration.ex Outdated Show resolved Hide resolved
lib/benchee/formatters/console.ex Outdated Show resolved Hide resolved
test/benchee/configuration_test.exs Outdated Show resolved Hide resolved
test/benchee/configuration_test.exs Show resolved Hide resolved
test/benchee/formatters/console_test.exs Show resolved Hide resolved
test/benchee/formatters/tagged_save_test.exs Outdated Show resolved Hide resolved
test/benchee_test.exs Show resolved Hide resolved
Now if inputs are given as an ordered list of tuples, the output will be
in the same order as the list of inputs given instead of sorted by the
input alphabetically.

I also updated some dependencies to get them on the same page as the
formatters, and fixed some Credo issues.
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another small thing and realized afterwards that you probably didn't get aroudn to addressing the other comments yet. No hurry 💃

lib/benchee/configuration.ex Outdated Show resolved Hide resolved
lib/benchee/configuration.ex Outdated Show resolved Hide resolved
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@PragTob PragTob merged commit a65bb81 into master Dec 10, 2018
@PragTob PragTob deleted the Issue-123 branch December 10, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Allow inputs to be an ordered list of tuples
3 participants