Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations #257

Merged
merged 5 commits into from Mar 26, 2019
Merged

Deprecations #257

merged 5 commits into from Mar 26, 2019

Conversation

devonestes
Copy link
Collaborator

This builds off #255, so that should be reviewed first.

This PR just adds deprecations for the things that we'll be removing in #256 so folks have some help in upgrading before that stuff is removed.

@devonestes
Copy link
Collaborator Author

@PragTob I think once this is merged we can release this as 0.99, and then #256 can be merged and released as 1.0.0-rc.1!

@PragTob
Copy link
Member

PragTob commented Dec 30, 2018

👋

Sorry for the absence and thanks a ton for the work! 💚

I think first we need to figure out the formatters, I think current benchee_json master and benchee_html master are incompatible ad I always want to have them all work on release. I'll try to put some time in to them.

I've also been bad and with background thinking came up with another thing I'd like to do before 1.0 😅 Issue opening to a repo near you soon

Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much great many wow otherwise, almost can't believe those are the only deprecations though 😅

img_20180818_152929

devonestes and others added 5 commits March 26, 2019 14:40
This adds deprecation warnings to all the things we'll be removing when
1.0 is released. We can probably release this as version 0.99 to make it
clear that this is just a release that adds deprecations before 1.0.
@PragTob
Copy link
Member

PragTob commented Mar 26, 2019

Messed around with this a bit, should be good to go 🎉

@PragTob PragTob merged commit 150771b into master Mar 26, 2019
@PragTob PragTob deleted the deprecations branch March 26, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants