Features/shoes4 #7
Conversation
|
Wow thanks I wanted to do this some time :-) But the good old oob authentication is kind of hard... :-/ Will see if I can find the time to dig in. feedzirra has a C dependency, we might need to get a different library to do the RSS/atom parsing :-) |
| source 'https://rubygems.org' | ||
|
|
||
| gem 'twitter' | ||
| gem 'oauth', '<0.4.0' |
There was a problem hiding this comment.
Shouldn't we go for a newer version of oauth? Might require a rewrite or so, but hey... :-)
There was a problem hiding this comment.
newer version depends on curb which in turn depends on cext - and new jruby does not have that by default ... maybe we do not need it at all?
There was a problem hiding this comment.
maybe the new twitter gem supports out of band authentication. I dunno. There should be some JRuby replacement for oauth if that doesn't work nonetheless :-)
There was a problem hiding this comment.
I will try to look into it later on today, maybe after lunch ;)
There was a problem hiding this comment.
doing some research now, in worst case I will implement this manually => https://dev.twitter.com/oauth/overview/authorizing-requests
There was a problem hiding this comment.
and found something that will not require re-implementing the wheel, with little effort I should get it working here, or in a gem ;) => https://github.com/lfcipriani/sign_in_with_twitter_sample/blob/master/lib/twitter_sign_in.rb
There was a problem hiding this comment.
stairs: lostisland/faraday_middleware#96
mpapis
force-pushed
the
features/shoes4
branch
from
26f651f
to
91dd601
Compare
|
still not working, but oauth is fine now ... at least the part with passing pincode works, did not tested what happens after that |
|
Just a question, why don't we use the oauth2 ? It's tested against JRuby as fara s I can see. |
|
Oauth2 implements protocol v2, it is not backwards compatible and twitter |
|
ugh. Bummer. Thanks Michal. |
|
btw, the tabs are totally broken in |
|
That sounds bad, will take a look. Have a working tab implementation for the pomodoro tracker - will gem that and port it over. |
|
Interesting, it seems like hide is broken... I thought I also used that in my pomdoro tracker. Investigating. |
|
Comparing the code of my slot_manager and the slot_manager used here I see no notable difference. I'm investigating where this difference comes from as it might as well be a shoes4 bug... |
|
tab hiding is fixed in shoes/shoes4#906 and another recent error on master I noticed in shoes/shoes4#907 edit: they should be merged soon |
|
ah this fixes are branches, I was wondering why there was no difference in behavior |
|
Yeah sorry - will probably get merged soon. Waiting a couple of days (or one or so) for a little review by one of my fellow contributors if they manage to find the time :-) |
git checkout -b PragTob
git pull git@github.com:shoes/shoes4.git slot-hide
git pull git@github.com:shoes/shoes4.git input-box-string-argumentsand tabs work now as expected, even some exception is gone from General... |
|
Yeah found that exception through running infoes/pomdoro tracker. It was a regression introduced through recent searches (was on a very old master before because apparently did all my shoes work from my laptop not my rig) Will land on master soon! |
|
Fixes on master now and soon in the pre2 gem release depending on whether I find problems now or not ;-) |
does start but does not authorize, do not merge yet