-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PsPingPlugin added #431
Conversation
@deyanp |
@deyanp I am just thinking: does it make sense to make a few calls and then take the average result? I guess that PsPing is behaving like this since it has a histogram and warmup |
* feat: PsPingPlugin added * feat: PsPingPlugin - PsPingPluginConfig.Timeout added * Update PsPingPlugin.fs * Delete build.sh * Update NBomber.fsproj Co-authored-by: Deyan Petrov <deyan@5gpay.com> Co-authored-by: Anton Moldovan <antyadev@gmail.com>
* feat: PsPingPlugin added * feat: PsPingPlugin - PsPingPluginConfig.Timeout added * Update PsPingPlugin.fs * Delete build.sh * Update NBomber.fsproj Co-authored-by: Deyan Petrov <deyan@5gpay.com> Co-authored-by: Anton Moldovan <antyadev@gmail.com>
@AntyaDev, yes, 100%, I was actually surprised that it only makes a single call (which is very unreliable). How can that be done? |
I think in case you don't have a timeout on the first call:
another way is to provide some percentiles but it can be used later, for now I think it's ok to use average |
@AntyaDev is it possible to make multiple pings during the load tests execution? |
I think that ping logic should be executed sequential to get the most correct results. parallel execution may affect the result. |
You are right. I will make the number of executions configurable, default to 4. I guess this PR is already closed, so I need to submit a new PR? |
yes, better new PR |
Did not really find unit tests for PingPlugin, so not sure what/how such should be created for PsPingPlugin ...