Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PsPingPlugin added #431

Merged
merged 5 commits into from
Nov 17, 2021
Merged

feat: PsPingPlugin added #431

merged 5 commits into from
Nov 17, 2021

Conversation

deyanp
Copy link
Contributor

@deyanp deyanp commented Nov 8, 2021

Did not really find unit tests for PingPlugin, so not sure what/how such should be created for PsPingPlugin ...

@AntyaDev
Copy link
Contributor

@deyanp
I think that later we can add UDP support too :)

@AntyaDev
Copy link
Contributor

@deyanp I am just thinking: does it make sense to make a few calls and then take the average result? I guess that PsPing is behaving like this since it has a histogram and warmup
https://docs.microsoft.com/en-us/sysinternals/downloads/psping

@AntyaDev AntyaDev merged commit 4123343 into PragmaticFlow:dev Nov 17, 2021
AntyaDev added a commit that referenced this pull request Nov 17, 2021
* feat: PsPingPlugin added

* feat: PsPingPlugin - PsPingPluginConfig.Timeout added

* Update PsPingPlugin.fs

* Delete build.sh

* Update NBomber.fsproj

Co-authored-by: Deyan Petrov <deyan@5gpay.com>
Co-authored-by: Anton Moldovan <antyadev@gmail.com>
AntyaDev added a commit that referenced this pull request Nov 17, 2021
* feat: PsPingPlugin added

* feat: PsPingPlugin - PsPingPluginConfig.Timeout added

* Update PsPingPlugin.fs

* Delete build.sh

* Update NBomber.fsproj

Co-authored-by: Deyan Petrov <deyan@5gpay.com>
Co-authored-by: Anton Moldovan <antyadev@gmail.com>
@deyanp
Copy link
Contributor Author

deyanp commented Nov 17, 2021

does it make sense to make a few calls and then take the average result?

@AntyaDev, yes, 100%, I was actually surprised that it only makes a single call (which is very unreliable). How can that be done?

@AntyaDev
Copy link
Contributor

AntyaDev commented Nov 17, 2021

I think in case you don't have a timeout on the first call:

  • you can retry this call (for example 3 times) via Seq.map
  • use Seq.average

another way is to provide some percentiles but it can be used later, for now I think it's ok to use average

@deyanp
Copy link
Contributor Author

deyanp commented Nov 17, 2021

@AntyaDev is it possible to make multiple pings during the load tests execution?

@AntyaDev
Copy link
Contributor

AntyaDev commented Nov 17, 2021

I think that ping logic should be executed sequential to get the most correct results.

parallel execution may affect the result.

@deyanp
Copy link
Contributor Author

deyanp commented Nov 17, 2021

You are right. I will make the number of executions configurable, default to 4.

I guess this PR is already closed, so I need to submit a new PR?

@AntyaDev
Copy link
Contributor

yes, better new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants