Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues pagination has incorrect number of pages #1350

Closed
mwest1066 opened this issue Oct 23, 2018 · 0 comments · Fixed by #3568
Closed

Issues pagination has incorrect number of pages #1350

mwest1066 opened this issue Oct 23, 2018 · 0 comments · Fixed by #3568
Labels
bug A bug or regression good first issue Great place to start for new contributors SQL Requires SQL code changes
Projects
Student dev Development Fall 2020 Development

Comments

@mwest1066
Copy link
Member

mwest1066 commented Oct 23, 2018 •
edited

When we paginate the issues list, we compute the number of pages (and whether we should paginate) based on the total issue count: https://github.com/PrairieLearn/PrairieLearn/blob/master/pages/instructorIssues/instructorIssues.js#L113

We should instead apply the filters when doing this, to obtain a count of the total number of issues with the current filter applied, and use this for pagination.

The change will require using issues_select_with_filter in BLOCK issues_count, in the same way as we do in BLOCK select_issues.
@mwest1066 mwest1066 added the bug A bug or regression label Oct 23, 2018
@mwest1066 mwest1066 added good first issue Great place to start for new contributors SQL Requires SQL code changes labels Mar 9, 2020
@mwest1066 mwest1066 added this to Proposed: simple in Student dev Mar 9, 2020
@mwest1066 mwest1066 added this to Instructor experience in Development Mar 29, 2020
@mwest1066 mwest1066 added this to To do in Fall 2020 Development via automation Sep 2, 2020
@mwest1066 mwest1066 moved this from To do to Ideas in Fall 2020 Development Sep 2, 2020
@mwest1066 mwest1066 mentioned this issue Oct 8, 2020
Closed
jonatanschroeder added a commit that referenced this issue Feb 16, 2021
@jonatanschroeder
Fix #3304 and #1350
0586dca
@jonatanschroeder jonatanschroeder mentioned this issue Feb 16, 2021
Merged
Fall 2020 Development automation moved this from Ideas to Done Feb 21, 2021
mwest1066 added a commit that referenced this issue Feb 21, 2021
@jonatanschroeder @mwest1066
Add more useful links from issues (#3568)
7df2245 
* Link assessment instance from question preview when showing variant linked to instance question

* Some simplifications in code, lint fix.

* Update reference to variants_select in variants_insert

* Fixed reference to assessment

* Restructuring of solution, to avoid confusion with the use of locals.assessment.

* Unified queries in variants_select.

* Bugfixes

* Bug fixes

* Update to properly show assessment links on assessment overview as instructor.

* Change issue list page to link to instance question when there is an instance

* Use plainUrlPrefix instead of /pl

* Build instructor URL prefix manually

* Add dropdown with other options for links

* Bugfix: wrong dropdown open

* Add link to manual grading page

* Styling issues and adding dropdown in issues not linked to instance

* Fix #3304 and #1350

* Restore page size

* Indentation

Co-authored-by: Matthew West <mwest@illinois.edu>

* Move links to text beside title

Co-authored-by: Matthew West <mwest@illinois.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug or regression good first issue Great place to start for new contributors SQL Requires SQL code changes
Projects
Development
Instructor experience
Fall 2020 Development
  
Done
Student dev
  
Proposed: simple
Milestone
No milestone
1 participant
@mwest1066