Convert manual grading assessment question page to TS

[jonatanschroeder]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 91.57609% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (3303c63) to head (ea73c9f).
Report is 2 commits behind head on master.

Files	Patch %	Lines
...arn/src/components/EditQuestionPointsScore.html.ts	84.73%	19 Missing and 1 partial ⚠️
...ding/assessmentQuestion/assessmentQuestion.html.ts	96.15%	5 Missing ⚠️
...smentInstance/instructorAssessmentInstance.html.ts	89.47%	4 Missing ⚠️
...rc/components/AssessmentOpenInstancesAlert.html.ts	95.65%	1 Missing ⚠️
...alGrading/assessmentQuestion/assessmentQuestion.ts	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10052      +/-   ##
==========================================
- Coverage   71.76%   71.67%   -0.09%     
==========================================
  Files         508      514       +6     
  Lines       80432    80955     +523     
  Branches     6792     6811      +19     
==========================================
+ Hits        57718    58028     +310     
- Misses      22256    22469     +213     
  Partials      458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

All images

Image	Platform	Old Size	New Size	Change
prairielearn/executor:ea73c9f722fe96768a18e41a7051e9f2ce097a0e	null	1178.81 MB	1178.88 MB	0.01%
prairielearn/prairielearn:ea73c9f722fe96768a18e41a7051e9f2ce097a0e	linux/amd64	1178.80 MB	1178.88 MB	0.01%

[jonatanschroeder]

This now combines the points and score forms, as they were very similar to each other, with the only difference being the suffix of the input element and the __action of the form (which is also combined, see below).

[jonatanschroeder]

This action was removed and replaced with an update to the edit_question_points action that performs either the update of points or score percentage. The code was almost identical anyway. Same thing in the assessment instance page.

[jonatanschroeder]

modified_at is a string because it needs to have the same precision as the PG code that retrieves it.

[nwalters512]

Checking my understanding: this is because Postgres dates have microsecond precision but JavaScript dates only have millisecond precision? Presumably we could clean this up by moving this check from SQL into JS?

PrairieLearn/apps/prairielearn/src/lib/manualGrading.sql

Lines 382 to 383 in c11b173

	$check_modified_at::TIMESTAMPTZ IS NOT NULL
	AND $check_modified_at != iq.modified_at AS modified_at_conflict

[jonatanschroeder]

Indeed. That would for sure be a valid alternative, but I'd prefer to do that in a separate PR.

[jonatanschroeder]

Given that this PR will create a merging conflict with #9887 and it's easier to fix that conflict here than there, this will remain as a draft until that PR is merged.

[nwalters512]

I did my best to review this but there's a lot here and my eyes glazed over after a while. As always, please let me know if there's anything specific you want me to look at or if you need help manually testing any of these changes.

[nwalters512]

Checking my understanding: this is because Postgres dates have microsecond precision but JavaScript dates only have millisecond precision? Presumably we could clean this up by moving this check from SQL into JS?

PrairieLearn/apps/prairielearn/src/lib/manualGrading.sql

Lines 382 to 383 in c11b173

	$check_modified_at::TIMESTAMPTZ IS NOT NULL
	AND $check_modified_at != iq.modified_at AS modified_at_conflict