Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Documentation Note For M-series Macs #10055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eldonwilliams
Copy link

I have added a note to the docker documentation to note platform must be specified on M-series Macs.

Copy link
Contributor

github-actions bot commented Jun 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.23%. Comparing base (d28a15d) to head (6f26c8b).
Report is 5 commits behind head on master.

Current head 6f26c8b differs from pull request most recent head a98fc52

Please upload reports for the commit a98fc52 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10055      +/-   ##
==========================================
- Coverage   69.25%   69.23%   -0.03%     
==========================================
  Files         484      484              
  Lines       76255    76255              
  Branches     6457     6453       -4     
==========================================
- Hits        52811    52793      -18     
- Misses      22994    23015      +21     
+ Partials      450      447       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/docker.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Sarang-Walters <nwalters512@gmail.com>
@nwalters512
Copy link
Contributor

@eldonwilliams you'll have to accept our CLA (see the above comment) and format your changes with make format-js to get CI to pass.

@eldonwilliams
Copy link
Author

I have reviewed and hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants