Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how binary files are handled during external grading #1489

Merged
merged 1 commit into from Apr 21, 2019
Merged

Fix how binary files are handled during external grading #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Expand Up @@ -195,6 +195,8 @@

* Fix (or at least attempt to) S3 file uploads for external grading (Nathan Walters).

* Fix handling of binary files during external grading (Nathan Walters).

* Remove `allowIssueReporting` option in `infoCourseInstance.json` (Matt West).

* Remove old temporary upgrade flag `tmp_upgraded_iq_status` (Matt West).
Expand Down
2 changes: 1 addition & 1 deletion lib/externalGraderCommon.js
View file
Open in desktop
Expand Up @@ -110,7 +110,7 @@ module.exports.buildDirectory = function(dir, submission, variant, question, cou
}

// Files are expected to be base-64 encoded
let decodedContents = Buffer.from(file.contents, 'base64').toString();
let decodedContents = Buffer.from(file.contents, 'base64');
fs.writeFile(path.join(dir, 'student', file.name), decodedContents, callback);
}, function(err) {
if (ERR(err, callback)) return;
Expand Down