chore: Refactor externalGraderLocal to use async/await #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to start chipping away at all of the code that's written with callbacks and converting it to
async/await, which is in general significantly easier to understand and maintain. I'm going to try to do a few of these PRs each week. Here's the first one, convertinglib/externalGraderLocal.jsto useasync/await.This was a pretty direct conversion. The only deliberate change of behavior here was that we no longer log each status update from
docker.pull(...). This was already pretty much useless, as it just logged a ton ofdocker pull output: [object Object].