Request additional information on request course page #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwest1066
reviewed
Mar 15, 2022
mwest1066
reviewed
Mar 15, 2022
|
Here is the behavior I am getting:
|
|
I would like to remove the column "User name" from being displayed in "administrator/overview" and also "administrator/courseRequests". Opinions? |
The URL Line 1551 in af962cd This code reads the data from the DB in it's SQL file here: The new fields will need to be added there. |
|
That makes sense! Thank you |
mwest1066
approved these changes
Mar 15, 2022
Co-authored-by: Matthew West <matt@prairielearn.com>
Co-authored-by: Matthew West <matt@prairielearn.com>
nwalters512
approved these changes
Mar 15, 2022
| @@ -33,7 +35,9 @@ | |||
| <tr> | |||
| <td class="align-middle"><%= req.short_name %></td> | |||
| <td class="align-middle"><%= req.title %></td> | |||
| <td class="align-middle"><%= req.user_name %></td> | |||
| <td class="align-middle"><%= req.first_name + ' ' + req.last_name %></td> | |||
There was a problem hiding this comment.
I'd consider including the user.name value here, just to see if it matches what they're self-reporting?
Suggested change
| <td class="align-middle"><%= req.first_name + ' ' + req.last_name %></td> | |
| <td class="align-middle"><%= req.first_name + ' ' + req.last_name %> (<%= req.user_name %>)</td> |
nwalters512
changed the title
nwalters512
pushed a commit
that referenced
this pull request
Apr 11, 2022
* added new fields to instructor form UI * added columns to db * changed type of email field in form * update alma message with new fields * added new parameters to course_requests_insert function and updated sprocs * updated sql code in sprocs * fixed email label * updated Admin UI with new columns * added new fields to admin course request * one more update - not sure is needed * added review updates * added new columns to admin overview sql * updated admin table to remove auth_name column * fixed migration number after merging master into branch * prettier fixes * updated the order of course_requests table * Update pages/administratorCourseRequests/courseRequestsTable.ejs Co-authored-by: Matthew West <matt@prairielearn.com> * Update pages/instructorRequestCourse/instructorRequestCourse.ejs Co-authored-by: Matthew West <matt@prairielearn.com> Co-authored-by: Matthew West <matt@prairielearn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more information to course request page, to facilitate the approval process.