fix: Don't error on 'null' in HTML templates #5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwest1066 as part of this PR, run |
nwalters512
approved these changes
Apr 1, 2022
Thanks for the reminder! Added in 48be0d2 |
nwalters512
pushed a commit
that referenced
this pull request
Apr 11, 2022
* fix: Don't render 'null' in HTML templates * Add test for null handling * Add changeset for html package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
typeof null === 'object', we would previously throw an error when trying to rendernullvalues:PrairieLearn/packages/html/src/index.ts
Line 12 in 69b1ad9
This PR also prints a more informative error message when an object can't be rendered.
@nwalters512 can you remind me how to release a new version of this library after this PR is merged?