Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl-matrix-component-input simplification #7198

Conversation

eliotwrobson
Copy link
Collaborator

See title. Part of #7027.

@eliotwrobson eliotwrobson self-assigned this Feb 26, 2023
@eliotwrobson
Copy link
Collaborator Author

eliotwrobson commented Apr 14, 2023

Going to go ahead and close this and extract some of the more useful components into a smaller PR. On further evaluation, the way that the pl-matrix-component-input element generates the HTML is kinda messy, and rather than extracting the functions doing this, it should be baked into a mustache template for a new element (perhaps just pl-matrix-input). Then, this element can have symbolic and numeric grading modes which grade relative to a reference matrix correct answer.

A lot of this is orthogonal to the work done here, and only really needs to be picked up if people find they really need symbolic matrix input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant