Convert submission insertion and grading selection sprocs to lib #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
All images
|
nwalters512
approved these changes
Feb 20, 2024
| VariantWithFormattedDateSchema, | ||
| ); | ||
|
|
||
| const variant = await sqldb.runInTransactionAsync(async () => { |
There was a problem hiding this comment.
I can't comment on the line, but: the group_work parameter to makeAndInsertVariant is now unused (and was in fact unused before - we passed it to the sproc, but the sproc did nothing with it). Consider removing to clean that up.
There was a problem hiding this comment.
Done in 79ff2ab. This actually cascaded into multiple functions that also only had that parameter to pass it along. I'll do another passthrough to ensure everything is fine before merging.
There was a problem hiding this comment.
It'd also be fine to save this for another, smaller PR if it cascades into too many changes.
There was a problem hiding this comment.
It was 5 functions, most of them local, so not too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.