feat: Multiple choice dropdown size attribute #9765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested locally, and it looks weird. I think auto makes sense, it sets the width to the widest option. Did you get any feedback on this? I don't think this change is necessary. |
|
I'll have to mess with it more, some people complained about it being too wide in some cases, but I think the extra width might be controllable by just sticking everything in a div. I think the weird display might be because of rendering latex, but not sure. If this acts weird in that case it's not worth merging. |
eliotwrobson
changed the title
Co-authored-by: Jonatan Schroeder <jonatan@yorku.ca>
jonatanschroeder
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
sizeparameter, the same as the free response elements, for the dropdown display mode on multiple choice. See docs for details: https://developer.snapappointments.com/bootstrap-select/examples/#width