Handle request for new variant when assessment is not available #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a non-broken variant exists, return the most recent one. Otherwise, tell the user that a new variant cannot be generated.
apps/prairielearn/src/pages/studentInstanceQuestion/studentInstanceQuestion.ejs
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/studentInstanceQuestion/studentInstanceQuestion.ejs
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/studentInstanceQuestion/studentInstanceQuestion.js
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/studentInstanceQuestion/studentInstanceQuestion.js
Outdated
Show resolved
Hide resolved
jonatanschroeder
approved these changes
May 6, 2024
There was a problem hiding this comment.
I'm happy with the way things are done here, but I'd prefer to defer to @mwest1066 or @nwalters512 for an additional look.
nwalters512
approved these changes
May 8, 2024
There was a problem hiding this comment.
A few stylistic nits, nothing blocking though. @echau01 let me know when you're ready for this to be merged.
apps/prairielearn/src/pages/studentInstanceQuestion/studentInstanceQuestion.js
Show resolved
Hide resolved
|
@echau01 there's a failing test that you'll need to fix before this can be merged. |
Exam questions are randomized, so we might visit the "broken generation" question and assume that a variant was created. Let's just remove the broken question from the test exam.
|
@nwalters512 I think everything's ready for merging now. |
nwalters512
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9030, resolves #1718.
If an assessment is not open or not active, and a student clicks a question in the assessment:
In both cases, we avoid generating a new variant.
Note: in my implementation, we do not show a broken variant. Not sure if this is right, but we can discuss it.