Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to change the highlighted areas #4

Closed
johannesfritsch opened this issue Nov 11, 2021 · 1 comment · Fixed by #5
Closed

Able to change the highlighted areas #4

johannesfritsch opened this issue Nov 11, 2021 · 1 comment · Fixed by #5
Assignees
@Pranomvignesh
Labels
bug Something isn't working

Comments

@johannesfritsch
Copy link

johannesfritsch commented Nov 11, 2021 •
edited

Hey! Very good job with your implementiation. It seems really solid. But still I found a way to change the highlighted sections:

https://www.youtube.com/watch?v=MhQWv1Gmnr4

To reproduce: Click into an editable area. Press Cmd+A, then press backspace.

Environment: Mac OS Big Sur + Chrome latest
@Pranomvignesh
Copy link
Owner

@johannesfritsch Thanks for reporting the issue.

Highlight is given for developers to make sure that their range configuration is properly working, and here I think the range restrictions are working fine and only the highlighted lines are having mismatch.

I will fix this soon

@Pranomvignesh Pranomvignesh added the bug Something isn't working label Nov 12, 2021
@Pranomvignesh Pranomvignesh self-assigned this Nov 21, 2021
@Pranomvignesh Pranomvignesh mentioned this issue Nov 21, 2021
Closed
@Pranomvignesh Pranomvignesh added the awaiting dependency This issue has its origin in a dependency package label Nov 21, 2021
Pranomvignesh added a commit that referenced this issue Nov 23, 2021
@Pranomvignesh
fix(highlight-areas-mismatch): the decorations are updated on undo wi…
f07f6a4 
…th the previous state

This is done as by design monaco editor wont track decoration ranges on undo, So this has to be done
by this way

fix #4
@Pranomvignesh Pranomvignesh removed the awaiting dependency This issue has its origin in a dependency package label Nov 23, 2021
@Pranomvignesh Pranomvignesh mentioned this issue Nov 23, 2021
Merged
@Lyannic Lyannic mentioned this issue Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pranomvignesh Pranomvignesh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@johannesfritsch @Pranomvignesh