Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-secrets 4 #723

Merged
merged 4 commits into from
Oct 17, 2022
Merged

helm-secrets 4 #723

merged 4 commits into from
Oct 17, 2022

Conversation

amadeusjposchmann
Copy link
Contributor

@amadeusjposchmann amadeusjposchmann commented Oct 17, 2022

Based on #721, but use stdout of helm-secrets directly, like in eyaml. Should fix #715.

  • fix: check helm plugin version
  • fix: use helm-secrets stdout on newer versions

Copy link
Collaborator

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisdavim luisdavim merged commit c147928 into Praqma:master Oct 17, 2022
mkubaczyk pushed a commit that referenced this pull request Aug 18, 2023
Co-authored-by: Luis Davim <luis.davim@gmail.com>
Co-authored-by: Luis Davim <luis.davim@sendoso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm-secrets plugin (>= 4.0.0) interaction broken
2 participants