allow use of metadata server for gcs authentication inside GCP #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
reviewed
Dec 24, 2022
luisdavim
reviewed
Dec 24, 2022
chrisSawarzynski
force-pushed
the
master
branch
from
ca9344b
to
69331e4
Compare
mkubaczyk
pushed a commit
that referenced
this pull request
Aug 18, 2023
Co-authored-by: Krzysztof Sawarzyński <ksawarzynski@egnyte.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently helmsman requires certificate provided via GOOGLE_APPLICATION_CREDENTIALS or GCLOUD_CREDENTIALS environment variable to read charts from GCP.
When running inside GCP helmsman can use metadata server to authenticate as Service Account.
This change prevents helmsman from failing when no env variables are provided, but metadata server is available.