Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] sword swinging sounds #1

Closed
TheYahton opened this issue Feb 3, 2024 · 3 comments · Fixed by #2
Closed

[enhancement] sword swinging sounds #1

TheYahton opened this issue Feb 3, 2024 · 3 comments · Fixed by #2

Comments

@TheYahton
Copy link

Could you please add an attack sound?

@PraxTube
Copy link
Owner

PraxTube commented Feb 3, 2024

It's pretty easy to add and I actually meant to add some, but I couldn't find any that sound good (and I can't make my own). You got any?

PraxTube added a commit that referenced this issue Feb 5, 2024
@PraxTube
Copy link
Owner

PraxTube commented Feb 5, 2024

I added the swing sound with a slight random pitch shift. I think it's okay, though it perhaps needs a bit work. I think it's a bit weird that the sound is the same for every swing, perhaps it should be different when the player hits an enemy, reflects a projectile or just hits nothing. The sound is in this location.

PraxTube added a commit that referenced this issue Feb 5, 2024
PraxTube added a commit that referenced this issue Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants