feat(OG-Network): add presence #8366
Conversation
| presenceData.buttons = [ | ||
| { | ||
| label: "View", | ||
| url, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Please read our guideliness
Presences that use buttons should follow extra requirements:
Redirects to main page are prohibited.
Promoting websites by them is prohibited.
They can't display information you couldn't fit in other fields.
Redirecting directly to audio/video stream is prohibited.
There was a problem hiding this comment.
If using buttons, it should ideally be used on specific interesting routes rather than a catch-all button
|
|
||
| presence.setActivity(presenceData); | ||
|
|
||
| if (!startTime) startTime = Date.now(); |
| logo: "https://www.og-network.net/assets/logo.png", | ||
| }; | ||
|
|
||
| let startTime: number; |
There was a problem hiding this comment.
no reason to use this after my changes.
There was a problem hiding this comment.
startTime is only assigned, not really used. It can be removed.
Co-authored-by: Dark_Ville <42322979+DarkVillager@users.noreply.github.com> Signed-off-by: John Fries <w.bababooie@gmail.com>
Co-authored-by: Dark_Ville <42322979+DarkVillager@users.noreply.github.com> Signed-off-by: John Fries <w.bababooie@gmail.com>
Co-authored-by: Dark_Ville <42322979+DarkVillager@users.noreply.github.com> Signed-off-by: John Fries <w.bababooie@gmail.com>
Co-authored-by: Dark_Ville <42322979+DarkVillager@users.noreply.github.com> Signed-off-by: John Fries <w.bababooie@gmail.com>
| ], | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/6jC2EYO.png", | ||
| "thumbnail": "https://www.og-network.net/assets/logo.png", |
There was a problem hiding this comment.
The thumbnail should preferably be a wide promotional card or a screenshot if the first is not available.
| logo: "https://www.og-network.net/assets/logo.png", | ||
| }; | ||
|
|
||
| let startTime: number; |
There was a problem hiding this comment.
startTime is only assigned, not really used. It can be removed.
| presenceData.buttons = [ | ||
| { | ||
| label: "View", | ||
| url, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
If using buttons, it should ideally be used on specific interesting routes rather than a catch-all button
| }, | ||
| "service": "OG Network", | ||
| "description": { | ||
| "en": "OG Network website presence" |
There was a problem hiding this comment.
If possible, use an official description
theusaf
added
the
inactive
|
Closing for inactivity. You may open a new PR after resolving the issues mentioned in this one. |
Description
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected