Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Should requirement.txt warn if old (minor) version? #276

Closed
oscarlevin opened this issue Jun 24, 2022 · 2 comments
Closed

Discussion: Should requirement.txt warn if old (minor) version? #276

oscarlevin opened this issue Jun 24, 2022 · 2 comments

Comments

@oscarlevin
Copy link
Member

I find the warning message frightening when building, like I've done something wrong. But it's not my fault, it's the developers. Yes, we should keep this info as debug, and report it in pretext support. But @rbeezer does a good job at not breaking previous builds when he improves core, so I'm not really sure what we are warning users about. Perhaps when there is a critical error, we can inspect requirements.txt and suggest a user look at --help if we think a feature might have changed.

@StevenClontz
Copy link
Member

I disagree - you should not pip install --upgrade pretextbook unless you're also willing to update your requirements.txt, which I'd do after confirming my project builds with the new CLI version. Otherwise you're not being truthful in the requirements of your project.

@StevenClontz
Copy link
Member

Closing for now based on Zoom discussion, but we'll be on the lookout for user reports on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants