-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WeBWorK: support for a 2.17+ server #1767
Conversation
Is this ready to be tested against APEX, or do we still need work on |
I've already changed things to Make sure to disable caching if you try it out. But yes, I don't expect you would have a problem if you use this branch now with your 2.17 server. If you do, please let me know. It's working with the 2.17 I have in the AIM dev server. And of course this won't be in the CLI. |
Thanks! I'm trying to remember: was there a way to disable caching globally, or do we have to specify this in every ww problem with an image? |
What I do is with Firefox, open the developer tools. Go to the Network tab, and there is a checkbox to disable caching. Then as long as the developer tools are open, when you load a page it will never rely on cached things. |
Ah, OK. I thought you were referring to the cache on the webwork server: without cleaning it, a new build of webwork representations ends up using whatever images are in there instead of new ones. |
Yes, styling will change in significant ways.
I suspect you built with platform=runestone? The version changing is
intentional, but only with rs builds.
…On Fri, Jun 24, 2022, 2:57 PM Sean Fitzpatrick ***@***.***> wrote:
Looks like things are working as expected.
Still needs some CSS attention though:
[image: image]
<https://user-images.githubusercontent.com/16246721/175647681-930c4ea6-4369-49ca-a6be-7e1a20cd8186.png>
Only other thing I noticed: clicking the make interactive button gives you
a different question than the static version.
That isn't the case with the versions of the book using 2.16.
—
Reply to this email directly, view it on GitHub
<#1767 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEDOAAIDSSSDL3X6A4MGBTVQYAILANCNFSM5ZYC5JEQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I didn't set it to use Runestone. |
If you did not build for runestone, then I should be able to fix that
rerandinization issue.
…On Fri, Jun 24, 2022, 2:59 PM Alex Jordan ***@***.***> wrote:
Yes, styling will change in significant ways.
I suspect you built with platform=runestone? The version changing is
intentional, but only with rs builds.
On Fri, Jun 24, 2022, 2:57 PM Sean Fitzpatrick ***@***.***>
wrote:
> Looks like things are working as expected.
> Still needs some CSS attention though:
> [image: image]
> <https://user-images.githubusercontent.com/16246721/175647681-930c4ea6-4369-49ca-a6be-7e1a20cd8186.png>
>
> Only other thing I noticed: clicking the make interactive button gives
> you a different question than the static version.
> That isn't the case with the versions of the book using 2.16.
>
> —
> Reply to this email directly, view it on GitHub
> <#1767 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABEDOAAIDSSSDL3X6A4MGBTVQYAILANCNFSM5ZYC5JEQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Unless Runestone is a default now (I don't think it is) I've never put anything in the publication file for Runestone. I've got another book that I'm busy putting Runestone exercises into, but even that I'm not building for Runestone, since I don't have a Runestone server and it's a work in progress |
@Alex-Jordan: should I merge, or wait? If the latter, please then send me a clear green light. |
You can merge this, assuming you didn't find a problem with it that I missed. The above was in reference to |
Should be fixed now. For the record, it turns out building for Runestone is not the only thing that triggers PTX putting Runestone javascript into the page. That was what was leading to the randomization when we didn't want it. |
Excellent. Time to rebuild all the things. |
Oh, the thing I just fixed doesn't require a rebuild. I edited an AIM-hosted javascript file. So you should get no re-randomization if you do what you did before. |
Yeah, but all of my official HTML builds are temporarily using my production WeBWorK server instead of the one intended for PreTeXt. |
Pushed from Hyatt Place lobby. Limited testing, no website update yet. Forgot to annotate with PR #. Sorry. :-( At e5bb62a |
No description provided.