Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeBWorK: move Activate button #1874

Closed
wants to merge 1 commit into from

Conversation

Alex-Jordan
Copy link
Contributor

This PR is for discussion, until some details can be worked out. I'll start a discussion thread now and reference this PR.

@Alex-Jordan
Copy link
Contributor Author

Force pushed this following a rebase over master and resolving a conflict.

@rbeezer
Copy link
Collaborator

rbeezer commented Jan 21, 2023

Is this ready, then? Do you want it now, or still need a pause?

@Alex-Jordan
Copy link
Contributor Author

No, this is not good for at least two reasons.

  • Having the button off to the side doesn't work well with narrow situations like two-column or phone.
  • When for example Runestone renders an exercise independently, outside of the actual book, it does not get the pretext_add_on CSS applied and then this button is really bad.

So more experimentation/research is needed.

@bnmnetp
Copy link
Contributor

bnmnetp commented Jan 21, 2023

Alex,

I can include the required CSS if I know about it. The reason I hadn't included it recently was because I've not had to add CSS from PreTeXt or WebWork on the assignment page in the past. If it makes sense to to do that I'm perfectly happy to do so.

@Alex-Jordan Alex-Jordan deleted the activate branch September 14, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants