Feature/dwh component #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2023 11:15
…methods for getting data from database and also executing raw requests or calling stored procedures. Also, it provides high level of communication with the database by implementing contexts - plant, solcast and enercast - allowing us to communicate with the database without writing SQL queeries but just passing parameters if required. Also, unit tests are added aligned to the structure of the DWH component.
alydersen
approved these changes
Nov 21, 2023
tests/dwh/context/test_enercast.py
Outdated
| { | ||
| "plantname": "CC-LL", | ||
| "AssetName": "PredPV1", | ||
| "AssetId": "86358efb-c076-4bca-a775-0a63ec92d8ba", |
There was a problem hiding this comment.
Should these be randomised a bit more? Seems very realistic and possibly a security issue?
There was a problem hiding this comment.
Another thing: Since this is a public library I think we should stick to plant-names that are totally unrecognisable, like "SOMESITE" and "ANOTHERSITE".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.