Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant lifecycle tests #840

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Assistant lifecycle tests #840

merged 6 commits into from
Feb 12, 2024

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Feb 11, 2024

Closes a bug where manual assistant lifecycles were still calling delete automatically. Now lifecycles should work as described in docs:

  • full interactive use (e.g. instantiate a Python assistant and call say) will auto create / delete as necessary
  • context managers can force creation/ deletion to only happen once, at the open/close of the context
  • manual calls to create and delete will disable automatic behavior
  • loading from the API will disable automatic behavior

zzstoatzz
zzstoatzz approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@jlowin jlowin merged commit 6c503d8 into main Feb 12, 2024
13 of 14 checks passed
@jlowin jlowin deleted the assistants branch February 12, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlowin @zzstoatzz