Improve instructions/tool handling on assistant calls #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we started passing instructions/tools on every call, the code interpreter wasn't cast to an API type correctly, resulting in an error. This should fix it.
jlowin
commented
Mar 22, 2024
| run_kwargs["instructions"] = instructions | ||
|
|
||
| if tools := self._get_tools(): | ||
| run_kwargs["tools"] = [t.model_dump(mode="json") for t in tools] |
There was a problem hiding this comment.
This is the bugfix - we don't let the openai library do the json casting, we do it ourselves
jlowin
commented
Mar 22, 2024
| run_kwargs["model"] = self._get_model() | ||
| def _get_run_kwargs(self, thread: Thread = None, **run_kwargs) -> dict: | ||
| if instructions := self._get_instructions(thread=thread): | ||
| run_kwargs["instructions"] = instructions |
There was a problem hiding this comment.
if there are instructions, we always provide them
zzstoatzz
reviewed
Mar 22, 2024
| ) | ||
| assert run.steps[0].step_details.tool_calls[0].type == "code_interpreter" | ||
| output = float( | ||
| run.steps[-2].step_details.tool_calls[0].code_interpreter.outputs[0].logs |
zzstoatzz
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two small bugs that were unlikely to be encountered but present:
Applications, where the instructions contain the latest state object (so they need to be constantly refreshed). In practice, this would only be experienced by users that were using manual lifecycle management; with lazy lifecycles, the assistant (and instructions) are created on every call, meaning the bug couldn't impact.