Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logfire example #917

Merged
merged 9 commits into from
May 1, 2024
Merged

add logfire example #917

merged 9 commits into from
May 1, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented May 1, 2024

see https://github.com/PrefectHQ/marvin/blob/main/cookbook/logfire/README.md

and:

  • updates default chat completion model to be gpt-4 (from gpt-4-11-06) which I think redirects to 4 at this point but gpt-4 makes more sense to me
  • adds to top level setting max_tool_output_length to control length of tool outputs before truncating
  • fixes bug with marvin say FileHistory where if the chat_history.txt or whole directory is deleted, we repeatedly fail to save / read new history

@zzstoatzz zzstoatzz requested a review from jlowin May 1, 2024 01:43
@aaazzam aaazzam self-requested a review May 1, 2024 19:35
Copy link
Collaborator

@aaazzam aaazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵 🔥

@zzstoatzz zzstoatzz merged commit a35a7ba into main May 1, 2024
14 of 15 checks passed
@zzstoatzz zzstoatzz deleted the logfire branch May 1, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants