This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix ability to edit pages via GitHub edit link #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
suggested changes
Sep 16, 2022
There was a problem hiding this comment.
Thanks @tpdorsey! I have one suggestion for the README, but other than that this looks great!
README.md
Outdated
Comment on lines
1
to
8
| --- | ||
| description: prefect-aws provides pre-built Prefect tasks for working with Amazon Web Services. | ||
| tags: | ||
| - overview | ||
| - getting started | ||
| - installation | ||
| - examples | ||
| --- |
There was a problem hiding this comment.
This section gets rendered as a table by GitHub:
I think the best course of action would be to inject this section into this page into the gen_refs script that allows us to use README.md as the index page for our docs.
There was a problem hiding this comment.
Ah I see my mistake here. We should remove this from the readme. My bad. It's fine on the other pages.
desertaxle
reviewed
Sep 16, 2022
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
ahuang11
approved these changes
Sep 16, 2022
desertaxle
approved these changes
Sep 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix misconfigured edit path to enable submitting edits via the "Pencil" edit link.
In addition:
Relevant Issue(s)
Checklist