Add Azure Container Instances infrastructure block #45
Conversation
…er and credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks so much for taking this on! Left a few comments and suggestions.
Also, once you start adding tests, can you also add example usage at the top of the module?
Really appreciate this!
…s a default if missing
Co-authored-by: Michael Adkins <contact@zanie.dev>
Everything worked during manual testing with all the latest changes incorporated. The README examples needed minor changes but they now work as expected. I'll also have a longer tutorial ready to publish when we merge and release this so any user that wants to try this infra block will have an end-to-end guide that walks them through it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I have a couple of requests/suggestions related to code organization and naming. If you have any questions about any of my notes feel free to reach out!
…e identifier And updated tests accordingly
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
… used or discussed
Thanks for all the revisions! If a test run works with all the latest revisions, I think we can merge and make a prefect-azure release. |
No problem! It's been a pleasure working on this, and I appreciate all the helpful feedback and assistance. |
Following up re: testing, I did another round of manual testis with the latest changes and all my container instance flows ran successfully. |
Summary
This PR adds an Azure Container Instances infrastructure block. The block provides a serverless infrastructure option on Azure similar to
ECSTask
on AWS andCloudRunJob
on GCP.Working
Steps to QA
QA Done
Relevant Issue(s)
Closes #44
Checklist
<link to issue>
"