Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Updates polling log level #95

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Updates polling log level #95

merged 2 commits into from
Nov 16, 2022

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Nov 16, 2022 •
edited

Closes #94

Checklist

  • This pull request references any related issue by including "Closes #<ISSUE_NUMBER>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • Summarized PR's changes in CHANGELOG.md

zzstoatzz
zzstoatzz previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! out of curiosity, what prompted this change?

@desertaxle
Copy link
Member Author

lgtm! out of curiosity, what prompted this change?

@gabcoyne opened #94 which raises the issue that the primary flow of this collection is cluttering user logs. I think we can update the logging to be more selective, but this is a quick way to avoid cluttering user logs.

@desertaxle desertaxle merged commit 65e9751 into main Nov 16, 2022
@desertaxle desertaxle deleted the update-poll-log-level branch November 16, 2022 22:29
@ahuang11 ahuang11 mentioned this pull request Dec 1, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@ahuang11 ahuang11 Awaiting requested review from ahuang11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change poll log level
2 participants
@desertaxle @zzstoatzz