Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Addresses Windows compatibility issues #117

Merged
merged 10 commits into from Jan 20, 2023
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 20, 2023

  • Adds os to matrix in python-test workflow to run tests on Windows
  • Uses PurePosixPath to ensure the correct path separator is used when working with GCS blobs

Closes #116

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle marked this pull request as ready for review January 20, 2023 15:22
Copy link
Contributor

@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@desertaxle desertaxle merged commit dd2704c into main Jan 20, 2023
@desertaxle desertaxle deleted the windows-compatibility branch January 20, 2023 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward slash ("/") gets replaced by ("\\") when executing on windows 11
2 participants