Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prefect-orion] hpa looking for values on wrong places #30

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[prefect-orion] hpa looking for values on wrong places #30

merged 1 commit into from
Sep 13, 2022

Conversation

bosmak
Copy link
Contributor

@bosmak bosmak commented Sep 13, 2022

The values.yaml indicates that the configuration for the hpa would be under api.autoscalling.X but the current file looks at autoscalling.X

jamiezieziula
jamiezieziula approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@jamiezieziula jamiezieziula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks! 🚀

@jamiezieziula jamiezieziula merged commit dc07f40 into PrefectHQ:main Sep 13, 2022
@bosmak bosmak deleted the hpa-tmpl-diff-from-values-yaml branch September 13, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiezieziula jamiezieziula jamiezieziula approved these changes

@gabcoyne gabcoyne Awaiting requested review from gabcoyne

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bosmak @jamiezieziula