Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prefect-orion] create service account #32

Merged
merged 5 commits into from
Sep 16, 2022
Merged

[prefect-orion] create service account #32

merged 5 commits into from
Sep 16, 2022

Conversation

bosmak
Copy link
Contributor

@bosmak bosmak commented Sep 14, 2022

Currently, the deployment sets a service account to the deployment but it isn't created anywhere.

@jamiezieziula jamiezieziula self-assigned this Sep 15, 2022
@jamiezieziula jamiezieziula requested a review from a team as a code owner September 16, 2022 14:58
jamiezieziula
jamiezieziula approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@jamiezieziula jamiezieziula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - this looks good to me!

@jamiezieziula jamiezieziula merged commit 1159ea8 into PrefectHQ:main Sep 16, 2022
@jamiezieziula jamiezieziula added the enhancement An improvement of an existing feature label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiezieziula jamiezieziula jamiezieziula approved these changes

@gabcoyne gabcoyne Awaiting requested review from gabcoyne

@zanieb zanieb Awaiting requested review from zanieb

Assignees

@jamiezieziula jamiezieziula

Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bosmak @jamiezieziula