[agent] Adjust agent configuration settings #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiezieziula
requested review from
gabcoyne,
zanieb and
a team
as code owners
jawnsy
reviewed
Sep 22, 2022
jawnsy
reviewed
Sep 22, 2022
| {{- if and .Values.agent.config.accountId .Values.agent.config.workspaceId }} | ||
| {{- printf "%s/api/accounts/%s/workspaces/%s" .Values.agent.config.apiUrl .Values.agent.config.accountId .Values.agent.config.workspaceId | quote }} | ||
| {{- if eq .Values.agent.apiConfig "cloud" }} | ||
| {{- printf "%s/accounts/%s/workspaces/%s" .Values.agent.cloudApiConfig.cloudUrl .Values.agent.cloudApiConfig.accountId .Values.agent.cloudApiConfig.workspaceId | quote }} |
There was a problem hiding this comment.
I'm wondering if we could handle this instead by showing the API URL in the UI somewhere (we could have a page that explains to people how to install an agent for a given work queue, with an example command to run in the case of the Helm chart)
so maybe orion/cloud don't really need to be different after all?
There was a problem hiding this comment.
I don't think the Helm chart is mainstream enough to target from the UI. The core library already templates/generates the API URL when users do prefect cloud login and we've established that they should not be responsible for creating the path to their workspace. I think it's reasonable for the chart to do so as well 🤷♀️
jawnsy
previously approved these changes
Sep 22, 2022
gabcoyne
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #57, this better structures what configuration is needed for all agent deployments and delineates what is needed for agent deployments with prefect cloud versus configuration for agent deployments with a local orion instance.